Add Wavlake embed #416

2023-03-08T23:39:09Z

blastshielddown commented

2023-03-08 23:39:09 +00:00

(Migrated from github.com)

This enables the display of an embedded music player when people share links to tracks on Wavlake. The embedded player also is capable of boosting the track if the Alby extension (WebLN) is available and the wallet is capable of sending keysends. The boost button is not visible if WebLN is not available.

This enables the display of an embedded music player when people share links to tracks on Wavlake. The embedded player also is capable of boosting the track if the Alby extension (WebLN) is available and the wallet is capable of sending keysends. The boost button is not visible if WebLN is not available. <img width="637" alt="Screenshot 2023-03-08 at 5 31 08 PM" src="https://user-images.githubusercontent.com/77257032/223877215-0ebee103-e8c3-44ca-b9f9-957531b82212.png">

SamSamskies (Migrated from github.com) requested changes 2023-03-08 23:59:27 +00:00

SamSamskies (Migrated from github.com) left a comment

lgtm, but can you run yarn workspace @snort/app format to prettify your changes?

also, what do you think about removing the max width of the player? imo it looks better and that's how all the other player embeds are.

lgtm, but can you run `yarn workspace @snort/app format` to prettify your changes? also, what do you think about removing the max width of the player? imo it looks better and that's how all the other player embeds are. ![Screenshot 2023-03-08 at 5 50 21 PM](https://user-images.githubusercontent.com/3655410/223880240-7aac419a-d08b-46a6-b464-8438f31fc9cc.png)

SamSamskies commented

2023-03-09 00:02:51 +00:00

(Migrated from github.com)

Also heads up that the payment button doesn't work for me with Alby. I think i have the default setup with Alby.

Also heads up that the payment button doesn't work for me with Alby. I think i have the default setup with Alby. ![Screenshot 2023-03-08 at 6 00 33 PM](https://user-images.githubusercontent.com/3655410/223880572-4dddf7c9-5849-4b52-80e1-514d5ed34734.png)

blastshielddown commented

2023-03-09 00:34:02 +00:00

(Migrated from github.com)

Thanks @SamSamskies Prettified changes as requested.

Also yes, good call on layout. I extended the max width of the embedded player to take up the width of the component. See screenshot below.

As for the Alby failure, what you're seeing is expected if the wallet/node you're connected to does not support keysends. Planning to support more widely available payment methods in the future but keysend is available now and would like to roll this out for anyone who's interested in trying it.

Thanks @SamSamskies Prettified changes as requested. Also yes, good call on layout. I extended the max width of the embedded player to take up the width of the component. See screenshot below. As for the Alby failure, what you're seeing is expected if the wallet/node you're connected to does not support keysends. Planning to support more widely available payment methods in the future but keysend is available now and would like to roll this out for anyone who's interested in trying it. <img width="619" alt="Screenshot 2023-03-08 at 6 31 55 PM" src="https://user-images.githubusercontent.com/77257032/223884292-61423705-9ef5-4aef-913d-cae90fc58906.png">

👍 1

SamSamskies (Migrated from github.com) approved these changes 2023-03-09 02:27:56 +00:00

SamSamskies (Migrated from github.com) left a comment

🚀