User preferences #104

2023-01-20T17:08:21Z

v0l commented

2023-01-20 17:08:21 +00:00

(Migrated from github.com)

Closes #40

cloudflare-pages[bot] commented

2023-01-20 17:09:18 +00:00

(Migrated from github.com)

Deploying with Cloudflare Pages

Latest commit:	`87c2baf`
Status:	✅ Deploy successful!
Preview URL:	https://8274017e.snort-social.pages.dev
Branch Preview URL:	https://preferences.snort-social.pages.dev

View logs

## Deploying with  <a href="https://pages.dev"><img alt="Cloudflare Pages" src="https://user-images.githubusercontent.com/23264/106598434-9e719e00-654f-11eb-9e59-6167043cfa01.png" width="16"></a>  Cloudflare Pages <table><tr><td><strong>Latest commit:</strong> </td><td> <code>87c2baf</code> </td></tr> <tr><td><strong>Status:</strong></td><td> ✅  Deploy successful!</td></tr> <tr><td><strong>Preview URL:</strong></td><td> <a href='https://8274017e.snort-social.pages.dev'>https://8274017e.snort-social.pages.dev</a> </td></tr> <tr><td><strong>Branch Preview URL:</strong></td><td> <a href='https://preferences.snort-social.pages.dev'>https://preferences.snort-social.pages.dev</a> </td></tr> </table> [View logs](https://dash.cloudflare.com/?to=/:account/pages/view/snort-social/8274017e-7b27-424b-a79b-2a29a4f17cd2)

verbiricha (Migrated from github.com) reviewed 2023-01-20 17:49:21 +00:00

verbiricha (Migrated from github.com) left a comment

minor comments, lgtm

src/Pages/Layout.tsx

verbiricha (Migrated from github.com) commented

2023-01-20 17:41:20 +00:00

we can just do elm.classList.toggle("light")

we can just do `elm.classList.toggle("light")`

src/Pages/settings/Index.css

verbiricha (Migrated from github.com) commented

2023-01-20 17:42:09 +00:00

    background-color: var(--note-bg);
    cursor: pointer;

```suggestion background-color: var(--note-bg); cursor: pointer; ```

src/Pages/settings/Preferences.tsx

verbiricha (Migrated from github.com) commented

2023-01-20 17:49:00 +00:00

Wdyt about keeping current default (use system theme)? If user explicitly sets a theme we can override it but if not use system theme. Have my devices configured to use dark/light depending on time of the day, don't want to be manually changing it from preferences.

This would be similar to other preferences, keeping the current default but offering customization.

Wdyt about keeping current default (use `system` theme)? If user explicitly sets a theme we can override it but if not use system theme. Have my devices configured to use dark/light depending on time of the day, don't want to be manually changing it from preferences. This would be similar to other preferences, keeping the current default but offering customization.