Add note context menu #105

2023-01-20T23:00:49Z

v0l commented

2023-01-20 23:00:49 +00:00

(Migrated from github.com)

cloudflare-pages[bot] commented

2023-01-20 23:01:49 +00:00

(Migrated from github.com)

Deploying with Cloudflare Pages

Latest commit:	`b2f1818`
Status:	✅ Deploy successful!
Preview URL:	https://a32c08eb.snort-social.pages.dev
Branch Preview URL:	https://note-ctx-menu.snort-social.pages.dev

View logs

## Deploying with  <a href="https://pages.dev"><img alt="Cloudflare Pages" src="https://user-images.githubusercontent.com/23264/106598434-9e719e00-654f-11eb-9e59-6167043cfa01.png" width="16"></a>  Cloudflare Pages <table><tr><td><strong>Latest commit:</strong> </td><td> <code>b2f1818</code> </td></tr> <tr><td><strong>Status:</strong></td><td> ✅  Deploy successful!</td></tr> <tr><td><strong>Preview URL:</strong></td><td> <a href='https://a32c08eb.snort-social.pages.dev'>https://a32c08eb.snort-social.pages.dev</a> </td></tr> <tr><td><strong>Branch Preview URL:</strong></td><td> <a href='https://note-ctx-menu.snort-social.pages.dev'>https://note-ctx-menu.snort-social.pages.dev</a> </td></tr> </table> [View logs](https://dash.cloudflare.com/?to=/:account/pages/view/snort-social/a32c08eb-7564-4ac0-9b1f-0154c2a4d5ee)

verbiricha (Migrated from github.com) approved these changes 2023-01-21 08:08:08 +00:00

verbiricha (Migrated from github.com) left a comment

minor comments, lgtm :shipit:

src/Element/NoteFooter.tsx

verbiricha (Migrated from github.com) commented

2023-01-21 08:06:38 +00:00

When we add note mention we could add another option here for copying the raw note id so you can paste it in a note for mentioning it.

src/Element/NoteFooter.tsx

verbiricha (Migrated from github.com) commented

2023-01-21 08:07:55 +00:00

wdyt about removing a bit of x padding? looks a bit wide.

<img width="769" alt="Screenshot 2023-01-21 at 09 06 59" src="https://user-images.githubusercontent.com/92299987/213857725-b692132c-f146-459b-8a9f-0144b693c8ed.png"> wdyt about removing a bit of x padding? looks a bit wide.

verbiricha (Migrated from github.com) reviewed 2023-01-21 08:08:57 +00:00

src/Element/Note.css

verbiricha (Migrated from github.com) commented

2023-01-21 08:08:57 +00:00

I think we should pad this so is aligned with note body.

  margin-top: 12px;
  padding-left: 56px;

I think we should pad this so is aligned with note body. ```suggestion margin-top: 12px; padding-left: 56px; ```

v0l (Migrated from github.com) reviewed 2023-01-21 11:59:12 +00:00

src/Element/NoteFooter.tsx

v0l (Migrated from github.com) commented

2023-01-21 11:59:11 +00:00

![image](https://user-images.githubusercontent.com/1172179/213865840-ec01a227-04e0-4e40-ace3-dbcff2b4e94a.png)

v0l (Migrated from github.com) reviewed 2023-01-21 11:59:47 +00:00

src/Element/Note.css

v0l (Migrated from github.com) commented

2023-01-21 11:59:47 +00:00

![image](https://user-images.githubusercontent.com/1172179/213865857-14c88c97-dc60-409e-b06a-ea77fbbd6a93.png)

Sign in to join this conversation.

No reviewers

verbiricha

No Label

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Kieran/snort#105