feat: add support for positive and negative reactions #11

2023-01-06T15:49:27Z

verbiricha commented

2023-01-06 15:49:27 +00:00

(Migrated from github.com)

No description provided.

cloudflare-pages[bot] commented

2023-01-06 15:52:03 +00:00

(Migrated from github.com)

Deploying with Cloudflare Pages

Latest commit:	`e2b9b22`
Status:	✅ Deploy successful!
Preview URL:	https://357bc150.snort-social.pages.dev
Branch Preview URL:	https://reactions.snort-social.pages.dev

View logs

## Deploying with  <a href="https://pages.dev"><img alt="Cloudflare Pages" src="https://user-images.githubusercontent.com/23264/106598434-9e719e00-654f-11eb-9e59-6167043cfa01.png" width="16"></a>  Cloudflare Pages <table><tr><td><strong>Latest commit:</strong> </td><td> <code>e2b9b22</code> </td></tr> <tr><td><strong>Status:</strong></td><td> ✅  Deploy successful!</td></tr> <tr><td><strong>Preview URL:</strong></td><td> <a href='https://357bc150.snort-social.pages.dev'>https://357bc150.snort-social.pages.dev</a> </td></tr> <tr><td><strong>Branch Preview URL:</strong></td><td> <a href='https://reactions.snort-social.pages.dev'>https://reactions.snort-social.pages.dev</a> </td></tr> </table> [View logs](https://dash.cloudflare.com/?to=/:account/pages/view/snort-social/357bc150-ef37-484c-af84-9b43aea93a1d)

v0l (Migrated from github.com) reviewed 2023-01-06 15:53:52 +00:00

src/element/Note.js

v0l (Migrated from github.com) commented

2023-01-06 15:53:42 +00:00

Not all likes use + for content, reactions vary a lot between clients, on Damus they use 🤙

Not all likes use `+` for content, reactions vary a lot between clients, on Damus they use 🤙

verbiricha (Migrated from github.com) reviewed 2023-01-06 16:15:38 +00:00

src/element/Note.js

verbiricha (Migrated from github.com) commented

2023-01-06 16:15:38 +00:00

What do you think is best, to have emoji reactions or like/dislike? Added support for 🤙

v0l (Migrated from github.com) reviewed 2023-01-06 18:17:16 +00:00

src/element/Note.js

v0l (Migrated from github.com) commented

2023-01-06 18:17:16 +00:00

I guess it would be pretty difficult to identify what is positive and what is negative outside of + & - since those are the only ones mentioned in the NIP, maybe its better not to distinguish them and to just show all reactions by their Content value https://github.com/nostr-protocol/nips/blob/master/25.md

Or we can just map well known contents into + / - and the rest are just generic reactions:
921122bd89/src/element/NoteReaction.js (L15-L26)

I guess it would be pretty difficult to identify what is positive and what is negative outside of `+` & `-` since those are the only ones mentioned in the NIP, maybe its better not to distinguish them and to just show all reactions by their `Content` value https://github.com/nostr-protocol/nips/blob/master/25.md Or we can just map well known contents into `+` / `-` and the rest are just generic reactions: https://github.com/v0l/snort/blob/921122bd89810d9e300f01effd0aaaea23b36374/src/element/NoteReaction.js#L15-L26

verbiricha commented

2023-01-06 22:11:49 +00:00

(Migrated from github.com)

@v0l gotta work on having reactions data available elsewhere but this is looking good
Screenshot 2023-01-06 at 23 10 48

@v0l gotta work on having reactions data available elsewhere but this is looking good <img width="759" alt="Screenshot 2023-01-06 at 23 10 48" src="https://user-images.githubusercontent.com/92299987/211108589-a1527ede-93b0-4114-bdda-bb2b1948a2b2.png">

v0l (Migrated from github.com) approved these changes 2023-01-07 11:12:38 +00:00

v0l (Migrated from github.com) left a comment

This is likely to change in the future but probably fine for now!

Sign in to join this conversation.

No reviewers

v0l