Kieran
/
snort
5
14
Fork 14
Code Issues 53 Pull Requests 1 Packages Projects Releases 24 Wiki Activity

UI Changes for Profile & Preferences #133

Closed
FlannelDipole wants to merge 1 commits from propref-changes into main
pull from: propref-changes
merge into: Kieran:main
Conversation 0 Commits 1 Files Changed 2 +5 -5
FlannelDipole commented 2023-01-24 13:02:40 +00:00 (Migrated from github.com)
Copy Link

Changed

  • Message reactions -> "Message reaction options" and made it more clear what it does
  • "System (Default)" -> "System" to follow general UI standard

Added

  • " Buy NIP-05" instead of just "Buy" to clarify what exactly a person is buying
**Changed** - Message reactions -> "Message reaction options" and made it more clear what it does - "System (Default)" -> "System" to follow general UI standard **Added** - " Buy NIP-05" instead of just "Buy" to clarify what exactly a person is buying
v0l (Migrated from github.com) reviewed 2023-01-24 13:14:07 +00:00
src/Pages/settings/Preferences.tsx
@ -19,3 +19,3 @@
<select value={perf.theme} onChange={e => dispatch(setPreferences({ ...perf, theme: e.target.value} as UserPreferences))}>
<option value="system">System (Default)</option>
<option value="system">System</option>
<option value="light">Light</option>
v0l (Migrated from github.com) commented 2023-01-24 13:13:09 +00:00
Copy Link

Default refers to it being the default option, not the systems default theme

Default refers to it being the default option, not the systems default theme
src/Pages/settings/Preferences.tsx
v0l (Migrated from github.com) commented 2023-01-24 13:12:28 +00:00
Copy Link

"options" is plural but this is a single checkbox, i think "Enable Reactions" was better

"options" is plural but this is a single checkbox, i think "Enable Reactions" was better
src/Pages/settings/Profile.tsx
v0l (Migrated from github.com) commented 2023-01-24 13:13:50 +00:00
Copy Link

Buy button is inline with NIP-05 entry i think its clear enough what you are buying

Buy button is inline with NIP-05 entry i think its clear enough what you are buying

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
1000k

1M Sats on Offer

  
100k

100k Sats on Offer

  
10k

10k Sats on Offer

  
200k

200k Sats on Offer

  
20k

20k Sats on Offer

  
500k

400k Sats on Offer

  
50k

50k Sats On Offer

  
5k

5k sats on Offers

  
75k

75k Sats on Offer

  
backend

Issue needs work on snort-api

  
blocked:design

Waiting for UI/UX designs

  
bug

Something isn't working

  
dependencies

Pull requests that update a dependency file

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
P1

   
P2

   
P3

   
question

Further information is requested

  
scope:intl

   
scope:nip

   
scope:query_tracing

   
scope:ux

   
wontfix

This will not be worked on

No Label
1000k
100k
10k
200k
20k
500k
50k
5k
75k
backend
blocked:design
bug
dependencies
documentation
duplicate
enhancement
good first issue
help wanted
invalid
P1
P2
P3
question
scope:intl
scope:nip
scope:query_tracing
scope:ux
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Kieran/snort#133
No description provided.
Delete Branch "propref-changes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?