Nip42 (AUTH) #144

2023-01-26T10:23:35Z

v0l commented

2023-01-26 10:23:35 +00:00

(Migrated from github.com)

Seems to work fine, tested with 2 different relay implementations,

nostr-rs-relay and nostream are the 2 most popular relay softwares, we should also make sure to test it on these before merging

https://nip42.snort-social.pages.dev/

Closes #94

Seems to work fine, tested with 2 different relay implementations, `nostr-rs-relay` and `nostream` are the 2 most popular relay softwares, we should also make sure to test it on these before merging https://nip42.snort-social.pages.dev/ Closes #94

LiranCohen commented

2023-01-26 15:34:50 +00:00

(Migrated from github.com)

I tested it out a bit on my private relay, seems to be working well.

I noticed that it tries to AUTH against a server that is not marked to be read from, which I think it shouldn't do.

I noticed this because I thought my server had read settings set to true, but I only saw it AUTH successfully and not send any other REQ messages (or receive events).

https://github.com/v0l/snort/pull/145

I tested it out a bit on my private relay, seems to be working well. I noticed that it tries to AUTH against a server that is not marked to be read from, which I think it shouldn't do. I noticed this because I *thought* my server had read settings set to true, but I only saw it AUTH successfully and not send any other REQ messages (or receive events). https://github.com/v0l/snort/pull/145

verbiricha (Migrated from github.com) approved these changes 2023-01-28 14:50:13 +00:00

verbiricha (Migrated from github.com) left a comment

Nostream doesn't seem to support NIP-42 according to README, neither does nostr-rs-relay. We should test with them when they release NIP-42 support, code lgtm.

[Nostream](https://github.com/Cameri/nostream) doesn't seem to support NIP-42 according to README, neither does [nostr-rs-relay](https://github.com/scsibug/nostr-rs-relay). We should test with them when they release NIP-42 support, code lgtm.

src/Pages/Layout.tsx

verbiricha (Migrated from github.com) commented

2023-01-28 14:34:27 +00:00

we are not using result so can use useEffect

    useEffect(() => {

we are not using result so can use `useEffect` ```suggestion useEffect(() => { ```

v0l commented

2023-01-28 15:05:23 +00:00

(Migrated from github.com)

Nostream doesn't seem to support NIP-42 according to README, neither does nostr-rs-relay. We should test with them when they release NIP-42 support, code lgtm.

The good thing about this is, it doesnt matter if the relay supports it or not, so we can merge this anyway it will only respond to AUTH if the relay asks for it

> [Nostream](https://github.com/Cameri/nostream) doesn't seem to support NIP-42 according to README, neither does [nostr-rs-relay](https://github.com/scsibug/nostr-rs-relay). We should test with them when they release NIP-42 support, code lgtm. The good thing about this is, it doesnt matter if the relay supports it or not, so we can merge this anyway it will only respond to AUTH if the relay asks for it

cloudflare-pages[bot] commented

2023-01-28 16:59:02 +00:00

(Migrated from github.com)

Deploying with Cloudflare Pages

Latest commit:	`a9ec933`
Status:	✅ Deploy successful!
Preview URL:	https://9952c74c.snort-social.pages.dev
Branch Preview URL:	https://nip42.snort-social.pages.dev

View logs

## Deploying with  <a href="https://pages.dev"><img alt="Cloudflare Pages" src="https://user-images.githubusercontent.com/23264/106598434-9e719e00-654f-11eb-9e59-6167043cfa01.png" width="16"></a>  Cloudflare Pages <table><tr><td><strong>Latest commit:</strong> </td><td> <code>a9ec933</code> </td></tr> <tr><td><strong>Status:</strong></td><td> ✅  Deploy successful!</td></tr> <tr><td><strong>Preview URL:</strong></td><td> <a href='https://9952c74c.snort-social.pages.dev'>https://9952c74c.snort-social.pages.dev</a> </td></tr> <tr><td><strong>Branch Preview URL:</strong></td><td> <a href='https://nip42.snort-social.pages.dev'>https://nip42.snort-social.pages.dev</a> </td></tr> </table> [View logs](https://dash.cloudflare.com/?to=/:account/pages/view/snort-social/9952c74c-2774-4e88-9611-2324014f8555)

LiranCohen commented

2023-01-28 19:37:21 +00:00

(Migrated from github.com)

🎉

Sign in to join this conversation.

No reviewers

verbiricha