Kieran
/
snort
5
14
Fork 14
Code Issues 53 Pull Requests 1 Packages Projects Releases 24 Wiki Activity

fix: private key strength should be 256 bits. #435

Closed
susumuota wants to merge 1 commits from fix-private-key-strength into main
pull from: fix-private-key-strength
merge into: Kieran:main
Conversation 1 Commits 1 Files Changed 1 +1 -1
susumuota commented 2023-03-13 02:17:47 +00:00 (Migrated from github.com)
Copy Link

Added signature.

Hi! Thank you for creating a great client!

I think I found an issue about NIP-06 PR #425.

bip39.generateMnemonic(wordlist) generates 128 bit strength private keys.
In my opinion, it should be 256 bit if you replace secp.utils.randomPrivateKey() which generates 32 byte (256bit) private keys.

Added signature. --- Hi! Thank you for creating a great client! I think I found an issue about NIP-06 PR #425. `bip39.generateMnemonic(wordlist)` generates 128 bit strength private keys. In my opinion, it should be 256 bit if you replace `secp.utils.randomPrivateKey()` which generates 32 byte (256bit) private keys.
v0l (Migrated from github.com) approved these changes 2023-03-13 09:48:29 +00:00
v0l commented 2023-03-13 10:21:13 +00:00 (Migrated from github.com)
Copy Link

cd89da39dd

cd89da39ddf27a75cc7cb0023ec61ed62749096b

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
v0l
Labels
Clear labels   
1000k

1M Sats on Offer

  
100k

100k Sats on Offer

  
10k

10k Sats on Offer

  
200k

200k Sats on Offer

  
20k

20k Sats on Offer

  
500k

400k Sats on Offer

  
50k

50k Sats On Offer

  
5k

5k sats on Offers

  
75k

75k Sats on Offer

  
backend

Issue needs work on snort-api

  
blocked:design

Waiting for UI/UX designs

  
bug

Something isn't working

  
dependencies

Pull requests that update a dependency file

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
P1

   
P2

   
P3

   
question

Further information is requested

  
scope:intl

   
scope:nip

   
scope:query_tracing

   
scope:ux

   
wontfix

This will not be worked on

No Label
1000k
100k
10k
200k
20k
500k
50k
5k
75k
backend
blocked:design
bug
dependencies
documentation
duplicate
enhancement
good first issue
help wanted
invalid
P1
P2
P3
question
scope:intl
scope:nip
scope:query_tracing
scope:ux
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Kieran/snort#435
No description provided.
Delete Branch "fix-private-key-strength"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?