nostr package: NIP-07 #503

Kieran · 2023-04-09T18:20:46Z

sistemd commented

2023-04-09 18:20:46 +00:00

(Migrated from github.com)

Implement NIP-07 support in the nostr package. Make it so that the browser tests can be ran both with and without the window.nostr object being mocked.

I also ran the tests with nos2x and they all passed.

Implement NIP-07 support in the `nostr` package. Make it so that the browser tests can be ran both with and without the `window.nostr` object being mocked. I also ran the tests with `nos2x` and they all passed.

v0l (Migrated from github.com) reviewed 2023-04-09 18:20:46 +00:00

cloudflare-pages[bot] commented

2023-04-09 18:23:03 +00:00

(Migrated from github.com)

Deploying with Cloudflare Pages

Latest commit:	`1e5811b`
Status:	✅ Deploy successful!
Preview URL:	https://6144bb36.snort-social.pages.dev
Branch Preview URL:	https://nostr-package-window-nostr-o.snort-social.pages.dev

View logs

## Deploying with  <a href="https://pages.dev"><img alt="Cloudflare Pages" src="https://user-images.githubusercontent.com/23264/106598434-9e719e00-654f-11eb-9e59-6167043cfa01.png" width="16"></a>  Cloudflare Pages <table><tr><td><strong>Latest commit:</strong> </td><td> <code>1e5811b</code> </td></tr> <tr><td><strong>Status:</strong></td><td> ✅  Deploy successful!</td></tr> <tr><td><strong>Preview URL:</strong></td><td> <a href='https://6144bb36.snort-social.pages.dev'>https://6144bb36.snort-social.pages.dev</a> </td></tr> <tr><td><strong>Branch Preview URL:</strong></td><td> <a href='https://nostr-package-window-nostr-o.snort-social.pages.dev'>https://nostr-package-window-nostr-o.snort-social.pages.dev</a> </td></tr> </table> [View logs](https://dash.cloudflare.com/?to=/:account/pages/view/snort-social/6144bb36-8723-47a7-84f8-792f932f3185)

sistemd commented

2023-04-09 18:34:44 +00:00

(Migrated from github.com)

Not sure why Cloudflare is failing.

v0l commented

2023-04-17 13:35:26 +00:00

(Migrated from github.com)



TS2687: All declarations of 'nostr' must have identical modifiers.
--
19:23:00.633 | 12 \| declare global {
19:23:00.633 | 13 \|   interface Window {
19:23:00.633 | > 14 \|     nostr: {
19:23:00.634 | \|     ^^^^^
19:23:00.634 | 15 \|       getPublicKey: () => Promise<HexKey>;
19:23:00.634 | 16 \|       signEvent: (event: RawEvent) => Promise<RawEvent>;
19:23:00.635 | 17 \|       getRelays: () => Promise<Record<string, { read: boolean; write: boolean }>>;
19:23:00.635 |  
19:23:00.635 |  
19:23:00.694 | error Command failed with exit code 1.

``` TS2687: All declarations of 'nostr' must have identical modifiers. -- 19:23:00.633 | 12 \| declare global { 19:23:00.633 | 13 \| interface Window { 19:23:00.633 | > 14 \| nostr: { 19:23:00.634 | \| ^^^^^ 19:23:00.634 | 15 \| getPublicKey: () => Promise<HexKey>; 19:23:00.634 | 16 \| signEvent: (event: RawEvent) => Promise<RawEvent>; 19:23:00.635 | 17 \| getRelays: () => Promise<Record<string, { read: boolean; write: boolean }>>; 19:23:00.635 | 19:23:00.635 | 19:23:00.694 | error Command failed with exit code 1. ```

sistemd commented

2023-04-17 20:10:30 +00:00

(Migrated from github.com)

I'm a dumbass. Will run build next time.

I'm a dumbass. Will run `build` next time.

Kieran approved these changes 2023-05-04 12:56:44 +00:00

Kieran referenced this issue from a commit

2023-05-04 12:56:58 +00:00

Merge pull request '`nostr` package: NIP-07' (#503) from nostr-package-window-nostr-object into main

Kieran merged commit 551169c2c7 into main

2023-05-04 12:57:00 +00:00

Kieran deleted branch nostr-package-window-nostr-object