Kieran/snort
5
14
Fork 14
Code Issues 37 Pull Requests 1 Packages Projects Releases 24 Wiki Activity

feat: mentions #56

Merged
verbiricha merged 8 commits from mentions into main 2023-01-15 09:59:08 +00:00
Conversation 2 Commits 8 Files Changed 9 +210 -24
verbiricha commented 2023-01-14 10:09:09 +00:00 (Migrated from github.com)
Copy Link
No description provided.
cloudflare-pages[bot] commented 2023-01-14 10:09:55 +00:00 (Migrated from github.com)
Copy Link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: cafc589
Status: ✅  Deploy successful!
Preview URL: https://ec617d9b.snort-social.pages.dev
Branch Preview URL: https://mentions.snort-social.pages.dev

View logs

## Deploying with &nbsp;<a href="https://pages.dev"><img alt="Cloudflare Pages" src="https://user-images.githubusercontent.com/23264/106598434-9e719e00-654f-11eb-9e59-6167043cfa01.png" width="16"></a> &nbsp;Cloudflare Pages <table><tr><td><strong>Latest commit:</strong> </td><td> <code>cafc589</code> </td></tr> <tr><td><strong>Status:</strong></td><td>&nbsp;✅&nbsp; Deploy successful!</td></tr> <tr><td><strong>Preview URL:</strong></td><td> <a href='https://ec617d9b.snort-social.pages.dev'>https://ec617d9b.snort-social.pages.dev</a> </td></tr> <tr><td><strong>Branch Preview URL:</strong></td><td> <a href='https://mentions.snort-social.pages.dev'>https://mentions.snort-social.pages.dev</a> </td></tr> </table> [View logs](https://dash.cloudflare.com/?to=/:account/pages/view/snort-social/ec617d9b-2725-41dc-90c3-690415652567)
v0l (Migrated from github.com) reviewed 2023-01-14 12:50:45 +00:00
src/element/Textarea.js
v0l (Migrated from github.com) commented 2023-01-14 12:45:34 +00:00
Copy Link

nip5 includes

nip5 includes
v0l (Migrated from github.com) commented 2023-01-14 12:45:56 +00:00
Copy Link

This should be tsx now, can you convert it to TS?

This should be `tsx` now, can you convert it to TS?
src/feed/EventPublisher.js
v0l (Migrated from github.com) commented 2023-01-14 12:50:20 +00:00
Copy Link

Trying to remove hex keys i think, only npub / note keys should be extracted

Trying to remove hex keys i think, only `npub` / `note` keys should be extracted
verbiricha (Migrated from github.com) reviewed 2023-01-14 22:51:04 +00:00
src/feed/EventPublisher.js
verbiricha (Migrated from github.com) commented 2023-01-14 22:51:04 +00:00
Copy Link

Leaving note references out for now, this PR only adds pubkey mentions with bech32 notation.

Leaving note references out for now, this PR only adds pubkey mentions with bech32 notation.
verbiricha commented 2023-01-14 23:13:52 +00:00 (Migrated from github.com)
Copy Link

Should be much better after https://github.com/v0l/snort/issues/47 but this is a start.

Should be much better after https://github.com/v0l/snort/issues/47 but this is a start.
v0l (Migrated from github.com) approved these changes 2023-01-15 09:59:02 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
v0l
Labels
Clear labels   
1000k

1M Sats on Offer

  
100k

100k Sats on Offer

  
10k

10k Sats on Offer

  
200k

200k Sats on Offer

  
20k

20k Sats on Offer

  
500k

400k Sats on Offer

  
50k

50k Sats On Offer

  
5k

5k sats on Offers

  
75k

75k Sats on Offer

  
backend

Issue needs work on snort-api

  
blocked:design

Waiting for UI/UX designs

  
bug

Something isn't working

  
dependencies

Pull requests that update a dependency file

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
P1

   
P2

   
P3

   
question

Further information is requested

  
scope:intl

   
scope:nip

   
scope:query_tracing

   
scope:ux

   
wontfix

This will not be worked on

No Label
1000k
100k
10k
200k
20k
500k
50k
5k
75k
backend
blocked:design
bug
dependencies
documentation
duplicate
enhancement
good first issue
help wanted
invalid
P1
P2
P3
question
scope:intl
scope:nip
scope:query_tracing
scope:ux
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Kieran/snort#56
No description provided.
Delete Branch "mentions"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?