Modal, process.env.HTTP_CACHE #643

mmalmi · 2023-10-06T06:53:37Z

mmalmi commented

2023-10-06 06:53:37 +00:00

Optionally query uncached profiles from process.env.HTTP_CACHE
Close image modal on image click
Show modal gallery length only if greater than 1 (not 1/1)
Remove ProfileImage z-index (same as https://github.com/v0l/snort/pull/570)

* Optionally query uncached profiles from process.env.HTTP_CACHE * Close image modal on image click * Show modal gallery length only if greater than 1 (not 1/1) * Remove ProfileImage z-index (same as https://github.com/v0l/snort/pull/570)

mmalmi added 4 commits 2023-10-06 06:53:42 +00:00

d4a3e11d03 rm ProfileImage z-index

234167b749 close image modal on image click

58ba714d36 get uncached profiles from process.env.HTTP_CACHE

continuous-integration/drone/pr Build is failing Details

bf0af2d14e show modal gallery length only if greater than 1

mmalmi added 1 commit 2023-10-06 07:20:39 +00:00

continuous-integration/drone/pr Build is failing Details

0b5dc2d290 proper error handling in profile http cache

Kieran approved these changes 2023-10-06 08:27:29 +00:00

mmalmi added 2 commits 2023-10-06 08:31:47 +00:00

ef7fc458f6 optional animal name placeholders for profile names

continuous-integration/drone/pr Build encountered an error Details

40e05480e6 animal name placeholder in all getDisplayName calls

Kieran reviewed 2023-10-06 08:35:27 +00:00

packages/app/src/Element/User/DisplayName.tsx Outdated

						
				@ -0,0 +20,4 @@

				  if (user?.display_name) {

				    name = user.display_name;

				  } else if (user?.name) {

Kieran commented

2023-10-06 08:34:59 +00:00

Sometimes this is not enough, we also check the length is greater than 0 length

mmalmi commented

2023-10-06 08:58:16 +00:00

restored the check

Kieran marked this conversation as resolved

mmalmi added 1 commit 2023-10-06 08:57:57 +00:00

continuous-integration/drone/pr Build encountered an error Details

4e2b7e6bb9 check name.length > 0

mmalmi added 2 commits 2023-10-06 09:11:46 +00:00

efa303b68f rm unused const and comment

continuous-integration/drone/pr Build encountered an error Details

90ac55d561 extract some Note parts into separate files

Kieran approved these changes 2023-10-06 09:28:15 +00:00

Kieran merged commit 873ba0a1d2 into main

2023-10-06 09:38:30 +00:00

Kieran referenced this issue from a commit

2023-10-06 09:38:31 +00:00

Merge pull request 'Modal, process.env.HTTP_CACHE' (#643) from mmalmi/snort:main into main

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Kieran/snort#643