Profile urls, scrollbar, ProfilePage refactoring #646

						
				@ -0,0 +143,4 @@

				    const replaceWith = (username: string) => {

				      const current = window.location.pathname;

				      const npub = hexToBech32(NostrPrefix.PublicKey, user?.pubkey);

				      if (current.endsWith(`/${npub}`)) {

Kieran commented

2023-10-09 08:55:59 +00:00

you should be able to use navigate(`/${username`, { replace: true });

you should be able to use ```navigate(`/${username`, { replace: true });```

mmalmi commented

2023-10-09 12:19:43 +00:00

perfect!

mmalmi marked this conversation as resolved

packages/app/src/Pages/Profile/ProfilePage.tsx Outdated

						
				@ -0,0 +153,4 @@

				        replaceWith(username);

				      } else {

				        // do we want this? would need to support urls with dots like /fiatjaf.com

				        // replaceWith(user.nip05?.replace(/^_@/, ""));

Kieran commented

2023-10-09 08:57:05 +00:00

Probably dont want this, people can still use their nip5 directly though if they wanted

mmalmi marked this conversation as resolved

packages/app/src/Pages/Profile/ProfilePage.tsx Outdated

						
				@ -0,0 +156,4 @@

				        // replaceWith(user.nip05?.replace(/^_@/, ""));

				      }

				    }

				  }, [isVerified, user?.pubkey]);

Kieran commented

2023-10-09 09:00:03 +00:00

isVerified not used?

`isVerified` not used?

mmalmi marked this conversation as resolved

fernandoporazzi reviewed 2023-10-09 09:03:33 +00:00

packages/app/src/Element/Text.tsx Outdated

						
				@ -171,2 +171,4 @@

				      if (element.type === "media" && element.mimeType?.startsWith("image")) {

				        if (i > 0) {

				          chunks.push(<div className="mt10" />);

fernandoporazzi commented

2023-10-09 09:03:33 +00:00

This is just for margin top? Can't we control that without adding an empty div?

Kieran commented

2023-10-09 09:05:30 +00:00

Yea probably best to use css actually

mmalmi marked this conversation as resolved

fernandoporazzi reviewed 2023-10-09 09:26:07 +00:00

packages/app/src/Pages/Profile/ProfilePage.tsx Outdated

						
				@ -0,0 +69,4 @@

				  const [modalImage, setModalImage] = useState<string>("");

				  const aboutText = user?.about || "";

				  const npub = !id?.startsWith(NostrPrefix.PublicKey) ? hexToBech32(NostrPrefix.PublicKey, id || undefined) : id;

				  const { isVerified } = useIsVerified(user?.pubkey || "");

fernandoporazzi commented

2023-10-09 09:26:07 +00:00

We could change this hook on packages/app/src/Element/User/Nip05.tsx and make the pubkey param optional.

By doing so, we can avoid that OR operator when calling the hook.

We could change this hook on `packages/app/src/Element/User/Nip05.tsx` and make the `pubkey` param optional. By doing so, we can avoid that **OR** operator when calling the hook.

mmalmi commented

2023-10-09 12:58:46 +00:00

done

mmalmi marked this conversation as resolved

mmalmi added 1 commit 2023-10-09 12:46:06 +00:00