tailwind #651

mmalmi · 2023-10-15T20:58:07Z

mmalmi commented

2023-10-15 20:58:07 +00:00

add tailwind build tools
add colors to NoteFooter buttons
catch fetch errors in fetchProfile

* add tailwind build tools * add colors to NoteFooter buttons * catch fetch errors in fetchProfile

mmalmi force-pushed main from 0106d1631a to 347eafda50

2023-10-15 20:58:45 +00:00

Compare

Kieran reviewed 2023-10-15 21:03:19 +00:00

packages/app/src/Pages/settings/Relays.tsx Outdated

						
				@ -85,3 +85,3 @@

				        <FormattedMessage {...messages.Relays} />

				      </h3>

				      <div className="flex f-col mb10">

				      <div className="flex flex-col mb10">

Kieran commented

2023-10-15 21:01:26 +00:00

Should this be flex-column

Should this be `flex-column`

mmalmi commented

2023-10-15 21:06:14 +00:00

flex flex-col is the tailwind equivalent of our own .flex-column which sets both display: flex and flex-direction: column

`flex flex-col` is the tailwind equivalent of our own .flex-column which sets both `display: flex` and `flex-direction: column`

Kieran commented

2023-10-15 21:08:05 +00:00

Oh, because i seen flex-column in the other file, is that something else?

Oh, because i seen `flex-column` in the other file, is that something else?

mmalmi commented

2023-10-16 11:10:41 +00:00

flex-column is from index.css. They do the same thing, but would be more clear to use the tailwind classes going forward.

`flex-column` is from index.css. They do the same thing, but would be more clear to use the tailwind classes going forward.

Kieran marked this conversation as resolved

mmalmi force-pushed main from 347eafda50 to 0c7f605948

2023-10-16 11:11:50 +00:00

Compare

mmalmi force-pushed main from 0c7f605948 to 4aae5b8525

2023-10-16 11:45:26 +00:00

Compare

Kieran approved these changes 2023-10-16 15:10:18 +00:00

mmalmi force-pushed main from 4aae5b8525 to a47dc5bbbc

2023-10-16 15:10:36 +00:00

Compare

mmalmi merged commit a168465bdb into main

2023-10-16 15:12:06 +00:00

mmalmi referenced this issue from a commit

2023-10-16 15:12:06 +00:00

Merge pull request 'tailwind' (#651) from mmalmi/snort:main into main

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Kieran/snort#651