Kieran/snort
5
14
Fork 14
Code Issues 37 Pull Requests 1 Packages Projects Releases 24 Wiki Activity

Event & profile links #653

Merged
mmalmi merged 5 commits from mmalmi/snort:main into main 2023-10-18 07:06:49 +00:00
Conversation 0 Commits 5 Files Changed 19 +56 -47
mmalmi commented 2023-10-17 18:44:25 +00:00
Collaborator
Copy Link
  • CONFIG.eventLinkPrefix used for event links
  • remove /e/ and /p/ from note and profile links
* CONFIG.eventLinkPrefix used for event links * remove /e/ and /p/ from note and profile links
mmalmi added 2 commits 2023-10-17 18:44:35 +00:00
CONFIG.eventLinkPrefix
All checks were successful
continuous-integration/drone/pr Build is passing
Details
d9bd198e8d
mmalmi added 1 commit 2023-10-17 18:50:21 +00:00
CONFIG.profileLinkSuffix
All checks were successful
continuous-integration/drone/pr Build is passing
Details
2c7878ac7f
mmalmi changed title from Event links to Event & profile links 2023-10-17 18:58:41 +00:00
mmalmi added 1 commit 2023-10-17 19:02:55 +00:00
"share note" url
All checks were successful
continuous-integration/drone/pr Build is passing
Details
700db8f62c
Kieran approved these changes 2023-10-17 19:45:48 +00:00
packages/app/src/SnortUtils/index.ts Outdated
@ -111,0 +113,4 @@
/**
* Convert hex pubkey to bech32 link url
*/
export function profileLink(hex: HexKey, relays?: Array<string> | string) {
Kieran commented 2023-10-17 19:44:28 +00:00
Owner
Copy Link

This should be removed

This should be removed
mmalmi marked this conversation as resolved
packages/system/src/nostr-link.ts Outdated
@ -164,3 +164,3 @@
}
static fromEvent(ev: TaggedNostrEvent | NostrEvent) {
static fromEvent(ev: TaggedNostrEvent | NostrEvent, prefixHint = NostrPrefix.Event) {
Kieran commented 2023-10-17 19:45:32 +00:00
Owner
Copy Link

This seems like the wrong approach, if you want to adjust the prefix it would probably be simpler to do it at encode()

This seems like the wrong approach, if you want to adjust the prefix it would probably be simpler to do it at `encode()`
Kieran commented 2023-10-17 19:47:58 +00:00
Owner
Copy Link

There are a lot of places where i use fromEvent but not encode since NostrLink is passed around a lot, i dont care what the prefix is in those cases (nevent/note are both accepted)

There are a lot of places where i use `fromEvent` but not `encode` since `NostrLink` is passed around a lot, i dont care what the prefix is in those cases (`nevent`/`note` are both accepted)
mmalmi commented 2023-10-18 07:06:13 +00:00
Author
Collaborator
Copy Link

good point!

good point!
mmalmi marked this conversation as resolved
mmalmi added 1 commit 2023-10-18 07:05:51 +00:00
NostrLink.encode(prefix: NostrPrefix)
All checks were successful
continuous-integration/drone/pr Build is passing
Details
2e663dcb4c
mmalmi merged commit 81df18ea4e into main 2023-10-18 07:06:47 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Kieran
Labels
Clear labels   
1000k

1M Sats on Offer

  
100k

100k Sats on Offer

  
10k

10k Sats on Offer

  
200k

200k Sats on Offer

  
20k

20k Sats on Offer

  
500k

400k Sats on Offer

  
50k

50k Sats On Offer

  
5k

5k sats on Offers

  
75k

75k Sats on Offer

  
backend

Issue needs work on snort-api

  
blocked:design

Waiting for UI/UX designs

  
bug

Something isn't working

  
dependencies

Pull requests that update a dependency file

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
P1

   
P2

   
P3

   
question

Further information is requested

  
scope:intl

   
scope:nip

   
scope:query_tracing

   
scope:ux

   
wontfix

This will not be worked on

No Label
1000k
100k
10k
200k
20k
500k
50k
5k
75k
backend
blocked:design
bug
dependencies
documentation
duplicate
enhancement
good first issue
help wanted
invalid
P1
P2
P3
question
scope:intl
scope:nip
scope:query_tracing
scope:ux
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Kieran/snort#653
No description provided.
Delete Branch "mmalmi/snort:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?