feat: zaps #78

2023-01-17T23:29:36Z

verbiricha commented

2023-01-17 23:29:36 +00:00

(Migrated from github.com)

Embed zapped notes

- [ ] Embed zapped notes

cloudflare-pages[bot] commented

2023-01-17 23:30:29 +00:00

(Migrated from github.com)

Deploying with Cloudflare Pages

Latest commit:	`140d87e`
Status:	✅ Deploy successful!
Preview URL:	https://fe9c2450.snort-social.pages.dev
Branch Preview URL:	https://zaps.snort-social.pages.dev

View logs

## Deploying with  <a href="https://pages.dev"><img alt="Cloudflare Pages" src="https://user-images.githubusercontent.com/23264/106598434-9e719e00-654f-11eb-9e59-6167043cfa01.png" width="16"></a>  Cloudflare Pages <table><tr><td><strong>Latest commit:</strong> </td><td> <code>140d87e</code> </td></tr> <tr><td><strong>Status:</strong></td><td> ✅  Deploy successful!</td></tr> <tr><td><strong>Preview URL:</strong></td><td> <a href='https://fe9c2450.snort-social.pages.dev'>https://fe9c2450.snort-social.pages.dev</a> </td></tr> <tr><td><strong>Branch Preview URL:</strong></td><td> <a href='https://zaps.snort-social.pages.dev'>https://zaps.snort-social.pages.dev</a> </td></tr> </table> [View logs](https://dash.cloudflare.com/?to=/:account/pages/view/snort-social/fe9c2450-bd14-41e0-96aa-51d0e9ac939a)

v0l (Migrated from github.com) approved these changes 2023-01-18 10:14:42 +00:00

v0l (Migrated from github.com) left a comment

Awesome!

src/Hash.tsx

v0l (Migrated from github.com) commented

2023-01-18 10:10:58 +00:00

You can put this in Util?

verbiricha commented

2023-01-18 10:21:07 +00:00

(Migrated from github.com)

Follow-up PR implements zap sending (WIP) and has some improvements on this https://github.com/v0l/snort/pull/80

v0l (Migrated from github.com) requested changes 2023-02-04 12:47:22 +00:00

v0l (Migrated from github.com) left a comment

We should also validate that the ZapReceipt pubkey matches the pubkey listed in the recipients lightning service, otherwise i can just fake zaps to people

We should also validate that the `ZapReceipt` pubkey matches the pubkey listed in the recipients lightning service, otherwise i can just fake zaps to people

src/Element/Zap.tsx

v0l (Migrated from github.com) commented

2023-02-04 12:43:30 +00:00

This is wrong, were not using this format anymore, can you revert to previous?

The description tag contains the zap note and the hash of this should match the description hash of the invoice

This is wrong, were not using this format anymore, can you revert to previous? The `description` tag contains the zap note and the hash of this should match the description hash of the invoice